Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix, null pointer exception in data-transfer-handler #136

Merged
merged 1 commit into from
Jun 6, 2022

Conversation

zl03jsj
Copy link
Contributor

@zl03jsj zl03jsj commented Jun 2, 2022

Since GetDeal returns an error,

https://github.com/filecoin-project/venus-market/blob/4d8533af0138c2d003dade56ced721ae1eac1b23/retrievalprovider/datatransfer_handler.go#L42-L50

The first returned param deal would be nil,
Should not use it again, just returns the error is ok.

@zl03jsj zl03jsj requested a review from hunjixin June 2, 2022 09:14
@codecov-commenter
Copy link

Codecov Report

Merging #136 (973771a) into main (4d8533a) will increase coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #136      +/-   ##
==========================================
+ Coverage   18.75%   18.78%   +0.02%     
==========================================
  Files         169      169              
  Lines       17742    17735       -7     
==========================================
+ Hits         3328     3331       +3     
+ Misses      13980    13971       -9     
+ Partials      434      433       -1     
Flag Coverage Δ
unittests 18.78% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
retrievalprovider/datatransfer_handler.go 0.00% <0.00%> (ø)
blockstore/badger/blockstore.go 56.36% <0.00%> (+0.45%) ⬆️

@hunjixin hunjixin merged commit 2f37b1b into main Jun 6, 2022
@zl03jsj zl03jsj deleted the fix/null-pointer-exception-in-data_transfer_handler branch June 7, 2022 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants