Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade gateway go mod #184

Merged
merged 3 commits into from
Aug 30, 2022
Merged

chore: upgrade gateway go mod #184

merged 3 commits into from
Aug 30, 2022

Conversation

zl03jsj
Copy link
Contributor

@zl03jsj zl03jsj commented Aug 22, 2022

关联的Issues (Related Issues)

close filecoin-project/venus/issues/5210
one of sub tasks of filecoin-project/venus/issues/4894

改动 (Proposed Changes)

The latest venus-gateway removed some local defined interfaces which was replaced by interfaces defined invenus-shared,
Upgrade veus-gateway, and suit those changes.

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@zl03jsj zl03jsj self-assigned this Aug 22, 2022
@zl03jsj zl03jsj requested review from simlecode and hunjixin August 22, 2022 06:47
@zl03jsj zl03jsj marked this pull request as draft August 22, 2022 07:42
@codecov-commenter
Copy link

Codecov Report

Merging #184 (ed045bf) into master (c0ef02b) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #184      +/-   ##
==========================================
- Coverage   19.20%   19.20%   -0.01%     
==========================================
  Files         173      173              
  Lines       18658    18684      +26     
==========================================
+ Hits         3584     3588       +4     
- Misses      14623    14639      +16     
- Partials      451      457       +6     
Flag Coverage Δ
unittests 19.20% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/clients/gateway_client.go 0.00% <0.00%> (ø)
api/clients/modules.go 0.00% <0.00%> (ø)
api/clients/sign_client.go 0.00% <0.00%> (ø)
api/impl/market_event.go 0.00% <ø> (ø)
network/transport.go 0.00% <ø> (ø)
storageprovider/deal_tracker.go 0.00% <0.00%> (ø)
paychmgr/simple.go 78.45% <0.00%> (-2.05%) ⬇️
models/badger/paych.go 72.22% <0.00%> (-1.67%) ⬇️
piecestorage/storagemgr.go 62.50% <0.00%> (-0.94%) ⬇️
blockstore/badger/blockstore.go 55.90% <0.00%> (-0.46%) ⬇️
... and 5 more

@zl03jsj zl03jsj force-pushed the chore/upgrade-gateway branch from 457eb83 to 951e80e Compare August 25, 2022 07:44
@zl03jsj zl03jsj marked this pull request as ready for review August 25, 2022 07:52
simlecode
simlecode previously approved these changes Aug 29, 2022
Copy link
Collaborator

@simlecode simlecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+LGTM

@zl03jsj zl03jsj force-pushed the chore/upgrade-gateway branch from 2595c77 to 05bf0e9 Compare August 29, 2022 10:27
@zl03jsj zl03jsj requested a review from simlecode August 29, 2022 10:41
Copy link
Collaborator

@simlecode simlecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+LGTM

@zl03jsj zl03jsj merged commit d500ea7 into master Aug 30, 2022
@zl03jsj zl03jsj deleted the chore/upgrade-gateway branch August 30, 2022 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[venus-market]由于venus-gateway的相关改动, 升级market对gateway的go mod依赖.
3 participants