Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/tanlang/add unit test to models layer #200

Merged
merged 5 commits into from
Sep 20, 2022

Conversation

LinZexiao
Copy link
Collaborator

@LinZexiao LinZexiao commented Sep 16, 2022

关联的Issues (Related Issues)

close filecoin-project/venus#5235

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@LinZexiao LinZexiao force-pushed the feat/tanlang/add-unit-test-to-models-layer branch from b600da0 to 1e8ae0e Compare September 16, 2022 10:13
@LinZexiao LinZexiao force-pushed the feat/tanlang/add-unit-test-to-models-layer branch from 1e8ae0e to ceb9a68 Compare September 19, 2022 06:24
@LinZexiao LinZexiao requested a review from simlecode September 19, 2022 06:24
@codecov-commenter
Copy link

Codecov Report

Merging #200 (ceb9a68) into master (77893b4) will increase coverage by 4.60%.
The diff coverage is 71.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #200      +/-   ##
==========================================
+ Coverage   20.20%   24.80%   +4.60%     
==========================================
  Files         176      176              
  Lines       18541    18671     +130     
==========================================
+ Hits         3746     4632     +886     
+ Misses      14327    13476     -851     
- Partials      468      563      +95     
Flag Coverage Δ
unittests 24.80% <71.94%> (+4.60%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
models/mysql/testing.go 72.72% <69.74%> (-27.28%) ⬇️
models/mysql/db.go 54.06% <82.35%> (+49.19%) ⬆️
models/mysql/cid_info.go 78.57% <100.00%> (+78.57%) ⬆️
paychmgr/simple.go 80.49% <0.00%> (+2.04%) ⬆️
models/badger/db.go 40.96% <0.00%> (+7.22%) ⬆️
models/badger/storage_ask.go 65.11% <0.00%> (+16.27%) ⬆️
models/badger/retrieval_ask.go 65.11% <0.00%> (+16.27%) ⬆️
models/badger/storage_deal.go 72.83% <0.00%> (+19.75%) ⬆️
models/badger/retrieval_deal.go 62.33% <0.00%> (+23.37%) ⬆️
... and 7 more

Copy link
Contributor

@hunjixin hunjixin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hunjixin hunjixin merged commit 0b20156 into master Sep 20, 2022
@hunjixin hunjixin deleted the feat/tanlang/add-unit-test-to-models-layer branch September 20, 2022 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[venus-market]增加model数据层单元测试
4 participants