Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/tanlang/add metric explain #201

Merged
merged 3 commits into from
Sep 23, 2022
Merged

Feat/tanlang/add metric explain #201

merged 3 commits into from
Sep 23, 2022

Conversation

LinZexiao
Copy link
Collaborator

@LinZexiao LinZexiao commented Sep 20, 2022 •
edited
Loading

关联的Issues (Related Issues)

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前，需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

hunjixin
hunjixin approved these changes Sep 21, 2022
View reviewed changes
Copy link
Contributor

@hunjixin hunjixin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LinZexiao LinZexiao force-pushed the feat/tanlang/add-metric-explain branch from 66b250e to 3d424c3 Compare September 23, 2022 08:02
@LinZexiao LinZexiao force-pushed the feat/tanlang/add-metric-explain branch from 3d424c3 to 124f9bd Compare September 23, 2022 08:33
@LinZexiao LinZexiao force-pushed the feat/tanlang/add-metric-explain branch from 124f9bd to 1bec96a Compare September 23, 2022 09:35
@simlecode simlecode merged commit 4d6cb2a into master Sep 23, 2022
@simlecode simlecode deleted the feat/tanlang/add-metric-explain branch September 23, 2022 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simlecode simlecode simlecode left review comments

@hunjixin hunjixin hunjixin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LinZexiao @hunjixin @simlecode