Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: release v2.4.0-rc3 #223

Merged
merged 1 commit into from
Oct 19, 2022
Merged

chore: release v2.4.0-rc3 #223

merged 1 commit into from
Oct 19, 2022

Conversation

hunjixin
Copy link
Contributor

@hunjixin hunjixin commented Oct 19, 2022 •
edited
Loading

关联的Issues (Related Issues)

close

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前，需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

simlecode
simlecode approved these changes Oct 19, 2022
View reviewed changes
Copy link
Collaborator

@simlecode simlecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+LGTM

@hunjixin hunjixin self-assigned this Oct 19, 2022
@simlecode simlecode merged commit dec7edf into master Oct 19, 2022
@simlecode simlecode deleted the v2.4.0-rc3 branch October 19, 2022 08:16
simlecode pushed a commit that referenced this pull request Nov 3, 2022
@hunjixin @ta0li
@diwufeiwen @LinZexiao
Prep/v2.4.0 rc4 (#228)
36ac559 
* chore: release v2.4.0-rc3 (#223)

* opt(tools): Orders that are not allocated deals

* feat: reformat all code with gofumpt (#226)

* feat: reformat all code

* feat: divide unit test for models layer (#225)

* chore: update venus* dependencies version

Co-authored-by: 一页素书 <2931107265@qq.com>
Co-authored-by: Tiance <40375298+diwufeiwen@users.noreply.github.com>
Co-authored-by: LinZexiao <55120714+LinZexiao@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simlecode simlecode simlecode approved these changes

Assignees

@hunjixin hunjixin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hunjixin @simlecode