Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: backport: #261 #262

Merged
merged 1 commit into from
Dec 22, 2022
Merged

Chore: backport: #261 #262

merged 1 commit into from
Dec 22, 2022

Conversation

hunjixin
Copy link
Contributor

关联的Issues (Related Issues)

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@hunjixin hunjixin changed the base branch from master to release/v2.4.1 December 22, 2022 06:08
Copy link
Collaborator

@simlecode simlecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release/v2.4.1@0bbfe30). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 591a705 differs from pull request most recent head 22a5c99. Consider uploading reports for the commit 22a5c99 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             release/v2.4.1     #262   +/-   ##
=================================================
  Coverage                  ?   23.66%           
=================================================
  Files                     ?      173           
  Lines                     ?    19560           
  Branches                  ?        0           
=================================================
  Hits                      ?     4628           
  Misses                    ?    14153           
  Partials                  ?      779           
Flag Coverage Δ
unittests 23.66% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@simlecode simlecode merged commit 7ed4da3 into release/v2.4.1 Dec 22, 2022
@simlecode simlecode deleted the chore/backport_261 branch December 22, 2022 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants