Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add issue template #361

Merged
merged 2 commits into from
Jul 5, 2023
Merged

add issue template #361

merged 2 commits into from
Jul 5, 2023

Conversation

Fatman13
Copy link
Contributor

@Fatman13 Fatman13 commented Jul 3, 2023

关联的Issues (Related Issues)

close #359

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@Fatman13 Fatman13 added the C-docs Category: Developer productivity label Jul 3, 2023
@Fatman13 Fatman13 requested a review from simlecode July 3, 2023 06:20
@Fatman13 Fatman13 self-assigned this Jul 3, 2023
@Fatman13 Fatman13 requested a review from simlecode July 5, 2023 04:03
@codecov-commenter
Copy link

Codecov Report

Merging #361 (0658f2a) into master (34a7277) will decrease coverage by 0.04%.
The diff coverage is 20.41%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #361      +/-   ##
==========================================
- Coverage   20.81%   20.78%   -0.04%     
==========================================
  Files         190      193       +3     
  Lines       23086    23359     +273     
==========================================
+ Hits         4806     4855      +49     
- Misses      17501    17718     +217     
- Partials      779      786       +7     
Flag Coverage Δ
unittests 20.78% <20.41%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cli/storage-deals.go 3.91% <0.00%> (ø)
cli/util.go 3.90% <0.00%> (ø)
dagstore/modules.go 0.00% <0.00%> (ø)
models/repo/repo.go 100.00% <ø> (ø)
rpc/rpc.go 0.00% <0.00%> (ø)
tools/index/main.go 0.00% <0.00%> (ø)
models/badger/shard.go 14.28% <14.28%> (ø)
config/save.go 36.00% <50.00%> (ø)
models/mysql/db.go 63.38% <50.00%> (+0.07%) ⬆️
dagstore/wrapper.go 41.89% <55.55%> (+0.01%) ⬆️
... and 6 more

... and 2 files with indirect coverage changes

Copy link
Collaborator

@simlecode simlecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@simlecode simlecode merged commit 15eda02 into master Jul 5, 2023
@simlecode simlecode deleted the fatman13-p1 branch July 5, 2023 05:01
@Fatman13 Fatman13 restored the fatman13-p1 branch July 12, 2023 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-docs Category: Developer productivity
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add issue template? / 增加 issue 模板?
3 participants