Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace venus-gateway with sophon-gateway #135

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

simlecode
Copy link
Collaborator

关联的Issues (Related Issues)

filecoin-project/venus#5808

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@codecov-commenter
Copy link

Codecov Report

Merging #135 (eb17db8) into master (452ecda) will decrease coverage by 0.67%.
The diff coverage is 6.66%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #135      +/-   ##
==========================================
- Coverage   62.51%   61.84%   -0.67%     
==========================================
  Files          30       30              
  Lines        2142     2165      +23     
==========================================
  Hits         1339     1339              
- Misses        730      753      +23     
  Partials       73       73              
Flag Coverage Δ
unittests 61.84% <6.66%> (-0.67%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/rpc_impl.go 93.33% <ø> (ø)
cmds/client.go 0.00% <ø> (ø)
main.go 0.00% <0.00%> (ø)
marketevent/market_client.go 67.01% <ø> (ø)
marketevent/market_event.go 91.15% <ø> (ø)
marketevent/types.go 81.13% <ø> (ø)
proofevent/proof_client.go 67.00% <ø> (ø)
proofevent/proof_event.go 90.44% <ø> (ø)
proofevent/types.go 81.13% <ø> (ø)
testhelper/memwallet.go 57.97% <ø> (ø)
... and 8 more

Copy link
Contributor

@diwufeiwen diwufeiwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diwufeiwen diwufeiwen merged commit 868706b into master Jun 8, 2023
@diwufeiwen diwufeiwen deleted the feat/rename-project branch June 8, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants