This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
fix(ipns): fail fast and fix rpc encoding #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
suggested changes
Feb 8, 2023
hacdias
force-pushed
the
feat/fail-fast-getipnsrecord
branch
from
48dfb39
to
6474a77
Compare
|
@lidel updated with the NLDJSON parsing of the correct format. PR opened in Kubo to fix the wire-format: ipfs/kubo#9639. |
lidel
changed the title
lidel
approved these changes
Feb 10, 2023
There was a problem hiding this comment.
Thanks, this should be future-proof enough (given ipfs/kubo#9639).
lidel
force-pushed
the
feat/fail-fast-getipnsrecord
branch
from
e04aa0c
to
2e6d8d7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #10 (comment).
Also fixes the
routing.GetValuecall. I confused it with theCoreAPI.Routing().Get()which expects the path as a string.routing.ValueStoreexpects the multihash encoded version of the path.Also added this improvement and fix to the Gateway example: ipfs/boxo#158
Hopefully all this errors will be caught once we run this against the gateway tests.