Skip to content
This repository has been archived by the owner on Aug 12, 2020. It is now read-only.

add guide to creating your own ipfs transport #58

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

whyrusleeping
Copy link
Contributor

cc @diasdavid @lgierth @RichardLitt for review and feedback

@RichardLitt
Copy link
Contributor

RichardLitt commented Jul 28, 2016

@whyrusleeping I know spell checkers are annoying due to not knowing all of the terminology, but I think adding apostrophes in contractions, and capitalizing 'I' is something that needs to be done, and I don't think it's the reviewer's job to point out things like that. Can you do a pass with your spell checker before asking for feedback?

This is basically the same as asking me to do go fmt before submitted a golang PR, I think.

@@ -0,0 +1,199 @@
# Implementing a new libp2p transport
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in go

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be great to have one in js as well ;)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

of course :)

@daviddias
Copy link
Contributor

I believe it would help to understand if the blog post was divided into two sections: a) how to plug in the WebSockets transport into libp2p (just reusing the module that is already there and making a dial); b) how to design a transport for libp2p, taking into example how the WebSockets was built

@ghost
Copy link

ghost commented Oct 28, 2016

Is this good to go?

@ghost ghost added the needs review label Oct 28, 2016
@RichardLitt
Copy link
Contributor

No. It needs to be copy edited. I asked @whyrusleeping to go over it again. @whyrusleeping can you help with that? I can split it into two parts after that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants