feat: DAG API basics (get, put, rm) #112
Conversation
daviddias
commented
Jan 31, 2017
•
daviddias
commented
- implementation js-ipfs
- implementation in js-ipfs-api
- feat(dag): basics (put, get) js-ipfs-http-client#520
daviddias
force-pushed
the
feat/dag-api-basics
branch
from
61667a4 to
dd3396b
Compare
| } | ||
| }) | ||
|
|
||
| describe('.put', () => { |
There was a problem hiding this comment.
You should also get these nodes to check that they have been actually put in the correct way
There was a problem hiding this comment.
that is what happens in the get tests, this way put is tested in isolation and in conjunction with get
There was a problem hiding this comment.
But not for all the formats as far as I can see.
|
I'm divided in waiting for feedback on DAG API things and moving forward, I've been kind of waiting for more throughout feedback since last quarter and now I've so many 'little' things in my plate that it is impossible to achieve something during two weeks if I wait for a lot of RTT I'll just move fast for the dag.get dag.put and dag.resolve API in js-ipfs land and bring up what I need to happen in go-ipfs land to make it go through js-ipfs-api |
