Normalize KEY API

[hacdias]

• Normalize API with non-capitalized object fields
• Wait for Normalize KEY API js-ipfs-http-client#659 to be completed.
• Update Tests

Ref.: ipfs-inactive/js-ipfs-http-client#659

[hacdias]

@diasdavid done. Should be merged alongside with ipfs-inactive/js-ipfs-http-client#659.

[richardschneider]

@hacdias PR ipfs/js-ipfs#1133 has the implementation (core, cli and http) for the Key API. Waiting for approval from @diasdavid

With the case change, you will also need to change core to use lower case, because core and http-api must be compatible.

However, http must still return Capitalized names because that is the spec defined by go-ipfs. This allows a go client to use a js-ipfs daemon.

The cli can either talk directly to core or use http-api, so it must be changed to use lower case.

[hacdias]

@richardschneider oops! Didn't notice that PR.

I just made this (and ipfs-inactive/js-ipfs-http-client#659) because most of the JS API is using non-capitalized object fields and that's just like the Standard specification tells us.

As far as I understood:

• HTTP API must return capitalized names (so js-ipfs and go-ipfs must return them that way).
• External APIs (go-ipfs-api, js-ipfs-api, py-ipfs-api, ...) should be compliant to each language standard, which, in JS case, is to be non-capitalized.

Did I miss something?

Edit: please check #190 too.

[richardschneider]

@hacdias I think we are on the same page. When these normalize PRs are released, please ping me and I'll update ipfs/js-ipfs#1133

[hacdias]

@diasdavid do you agree with what I said?

[daviddias]

thank you both for figuring this out and reaching consensus. LGTM :)

[hacdias]

Thanks @diasdavid!
Pinging @richardschneider 😄