This repository was archived by the owner on Mar 10, 2020. It is now read-only.
Harden DHT tests #239
Merged
Harden DHT tests #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DHT doesn't work well with a low number of peers (the more the better). Hence increase it to 5 peers. This should make the test more reliable.
The DHT works best with >- 20 nodes, this means that the tests might fail (but it passes most of the time). Hence skip the query test before the timeout is reached.
ghost
assigned
9 tasks
daviddias
approved these changes
Mar 16, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make the tests not fail anymore. The number of nodes was increased so they should pass more often. Before the timeout is reached, the test is skipped. This means that it won't fail even if go-ipfs takes a long time/hangs.