This repository was archived by the owner on Mar 10, 2020. It is now read-only.
doc: You can't ipfs.add a path #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
daviddias
suggested changes
Mar 26, 2018
SPEC/FILES.md
Outdated
| @@ -16,7 +16,6 @@ Where `data` may be: | |||
| - a [`Buffer instance`][b] | |||
| - a [`Readable Stream`][rs] | |||
| - a [`Pull Stream`][ps] | |||
| - a Path (caveat: will only work in Node.js) | |||
| - a URL | |||
There was a problem hiding this comment.
remove the URL as well given that neither are supported at the moment.
|
@diasdavid done! |
daviddias
approved these changes
Mar 26, 2018
anthony-mills
added a commit
to anthony-mills/interface-ipfs-core
that referenced
this pull request
May 20, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests in js-ipfs-api explicitly assert that passing a file path string to
ipfs.addshould fail.https://github.com/ipfs/interface-ipfs-core/blob/b862a12bc655954143b995887983f96201abcf31/js/src/files.js#L144-L151
This PR removes "a Path" from the list of possible parameter types to
ipfs.addFixes ipfs-inactive/js-ipfs-http-client#722