[WIP] fix: ipns tests using go daemon #360
Conversation
ghost
assigned 
| @@ -125,7 +123,7 @@ module.exports = (createCommon, options) => { | |||
| ipfs.name.resolve(keyId, resolveOptions, (err, res) => { | |||
| expect(err).to.not.exist() | |||
| expect(res).to.exist() | |||
| expect(res.path).to.equal(`/ipfs/${value}`) | |||
| expect(res.path || res).to.equal(`/ipfs/${value}`) // TODO | |||
There was a problem hiding this comment.
This seems wrong, tests should test one thing and here is a conditional (res.path || res). Also the TODO seems to be missing a comment about what/why
There was a problem hiding this comment.
yes! That will be changed 🙂
But for explaining the purpose, I am experiencing different responses when the daemon is online and offline. One has the path property, while the other does not have. I will keep this in WIP before solving this
| @@ -83,12 +81,12 @@ module.exports = (createCommon, options) => { | |||
|
|
|||
| done() | |||
| }) | |||
| }, 1) | |||
| }, 10) | |||
There was a problem hiding this comment.
Rather than having this is a timeout, we should have something similar to this: https://github.com/ipfs/interface-ipfs-core/blob/master/js/src/pubsub/utils.js#L5-L31
Where we execute the expectations once every 100 milliseconds until either it passes or we've tried 10 times. This will make the test less likely to fail on lower performance machines.
alanshaw
changed the title
In the context of having the
ipnstests running on js-ipfs-api#841