Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

test: add test for ls by IPFS path #420

Merged
merged 3 commits into from
Dec 14, 2018
Merged

test: add test for ls by IPFS path #420

merged 3 commits into from
Dec 14, 2018

Conversation

alanshaw
Copy link
Contributor

@alanshaw alanshaw commented Dec 14, 2018

Alan Shaw added 2 commits December 14, 2018 16:52
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
@ghost ghost assigned alanshaw Dec 14, 2018
@ghost ghost added the in progress label Dec 14, 2018
alanshaw pushed a commit to ipfs-inactive/js-ipfs-http-client that referenced this pull request Dec 14, 2018
This was accidentally disabled and no tests existed to catch it.

* [ ] depends on ipfs-inactive/interface-js-ipfs-core#420

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
Copy link
Contributor

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vasco-santos
Copy link
Contributor

Linting errors, as exceed the max number of callbacks. Can you just add the eslint ignore?

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
@alanshaw alanshaw merged commit 570aaf0 into master Dec 14, 2018
@ghost ghost removed the in progress label Dec 14, 2018
@alanshaw alanshaw deleted the test/ls-by-path branch December 14, 2018 18:07
alanshaw pushed a commit to ipfs-inactive/js-ipfs-http-client that referenced this pull request Dec 15, 2018
This was accidentally disabled and no tests existed to catch it.

* [x] depends on ipfs-inactive/interface-js-ipfs-core#420

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants