Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

docs: clarify bootstrap add/remove optional params #557

Merged
merged 1 commit into from
Nov 14, 2019
Merged

docs: clarify bootstrap add/remove optional params #557

merged 1 commit into from
Nov 14, 2019

Conversation

alanshaw
Copy link
Contributor

No description provided.

@alanshaw alanshaw requested a review from achingbrain November 14, 2019 12:06
@alanshaw alanshaw mentioned this pull request Nov 14, 2019
Merged
achingbrain
achingbrain approved these changes Nov 14, 2019
View reviewed changes
Copy link
Collaborator

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good that this is clarified. It's a bad that it is what it is. Explicit ipfs.bootstrap.reset() and ipfs.bootstrap.empty() (for example) methods would be better, but that's a problem for another day.

@alanshaw
Copy link
Contributor Author

Yes, and the HTTP APIs exist:

@alanshaw alanshaw merged commit 1ac0722 into master Nov 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@achingbrain achingbrain achingbrain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alanshaw @achingbrain