This repository was archived by the owner on Mar 10, 2020. It is now read-only.
Make block API spec and tests coherent. #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
daviddias
commented
Aug 24, 2016
•
daviddias
commented
- Make tests follow what is prescribed in the Interface definiton
- Update js-ipfs-api
daviddias
force-pushed
the
feat/update-block-api
branch
3 times, most recently
from
1d33e4a to
da9c32d
Compare
|
RFM. This PR solves the incoherence between spec and tests. |
1 task
daviddias
force-pushed
the
feat/update-block-api
branch
from
da9c32d to
235c02f
Compare
|
LGTM |
10 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.