Skip to content
This repository has been archived by the owner on Oct 16, 2020. It is now read-only.

fix: ipfs connection test #18

Merged
merged 1 commit into from
Nov 9, 2018
Merged

fix: ipfs connection test #18

merged 1 commit into from
Nov 9, 2018

Conversation

fsdiogo
Copy link
Contributor

@fsdiogo fsdiogo commented Nov 9, 2018

ipfs.get() gets aliased to ipfs.files.get() in the HTTP API & CLI but not in the core. So when testing with a core instance it was breaking.

@fsdiogo fsdiogo self-assigned this Nov 9, 2018
@fsdiogo fsdiogo requested a review from olizilla November 9, 2018 11:48
@olizilla olizilla merged commit 2d31686 into master Nov 9, 2018
@olizilla olizilla deleted the fix/ipfs-connection-test branch November 9, 2018 11:56
@alanshaw
Copy link

Just a note - this will change to ipfs.get in 0.34 - sorry!

@fsdiogo
Copy link
Contributor Author

fsdiogo commented Nov 21, 2018

Thanks for the heads up @alanshaw 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants