Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

Remove gh urls from dependencies #1122

Closed
achingbrain opened this issue Oct 4, 2019 · 3 comments · Fixed by #1173
Closed

Remove gh urls from dependencies #1122

achingbrain opened this issue Oct 4, 2019 · 3 comments · Fixed by #1173

Comments

@achingbrain
Copy link
Collaborator

We have two deps that are pointing to gh repos. This can cause people to have problems using this module, like ipfs-shipyard/npm-on-ipfs#117

@hugomrdias if the changes you've made to these modules aren't going to get merged, could you just publish your forks under a different name?

@achingbrain
Copy link
Collaborator Author

Another person encountering the same issue: #1139

@alanshaw alanshaw added the ready label Nov 4, 2019
@alanshaw
Copy link
Contributor

alanshaw commented Nov 4, 2019

🙏 yes please!

@alanshaw alanshaw mentioned this issue Nov 5, 2019
@alanshaw
Copy link
Contributor

These are both (concat-stream & ndjson) likely to be removed in the async/await refactor

alanshaw pushed a commit that referenced this issue Nov 22, 2019
This is a round up of the remaining async/await PRs along with some cleanup and docs fixes.

resolves #1103
resolves #1122
resolves #1158 (hopefully!)
closes #1164
closes #1165
closes #1166
closes #1169
closes #1170
closes #1172

BREAKING CHANGE: The `log.tail` method now returns an async iterator that yields log messages. Use it like:

```js
for await (const message of ipfs.log.tail()) {
  console.log(message)
}
```

BREAKING CHANGE: The response to a call to `log.level` now returns an object that has camel cased keys. i.e. `Message` and `Error` properties have changed to `message` and `error`.

BREAKING CHANGE: Dropped support for go-ipfs <= 0.4.4 in `swarm.peers` response.

BREAKING CHANGE: The signature for `ipfs.mount` has changed from `ipfs.mount([ipfsPath], [ipnsPath])` to `ipfs.mount([options])`. Where `options` is an optional object that may contain two boolean properties `ipfsPath` and `ipnsPath`. The response object has also changed to be camel case. See https://docs.ipfs.io/reference/api/http/#api-v0-mount.

BREAKING CHANGE: Default ping `count` of 1 in client has been removed. The default ping count is now whatever the IPFS node defaults it to (currently 10). If you specifically need 1 ping message then please pass `count: 1` in options for `ipfs.ping()`.

BREAKING CHANGE: Multi parameter constructor options are no longer supported. To create a new IPFS HTTP client, pass a single parameter to the constructor. The parameter can be one of:

* String, formatted as one of:
    * Multiaddr e.g. /ip4/127.0.0.1/tcp/5001
    * URL e.g. http://127.0.0.1:5001
* [Multiaddr](https://www.npmjs.com/package/multiaddr) instance
* Object, in format of either:
    * Address and path e.g. `{ apiAddr: '/ip4/127.0.0.1/tcp/5001': apiPath: '/api/v0' }` (Note: `apiAddr` can also be a string in URL form or a Multiaddr instance)
    * Node.js style address e.g. `{ host: '127.0.0.1', port: 5001, protocol: 'http' }`
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants