Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

more feedback from ipfs add #567

Closed
MichaelMure opened this issue Jun 16, 2017 · 2 comments
Closed

more feedback from ipfs add #567

MichaelMure opened this issue Jun 16, 2017 · 2 comments

Comments

@MichaelMure
Copy link
Contributor

MichaelMure commented Jun 16, 2017

Currently, addFromFs and ipfs add only trigger the callback when everything is done or if an error occured. This has two problem:

  • there is no feedback of the progress during the operation.
  • all the stream of event of the daemon is buffered in memory and that can be expensive for a directory with a lot of files
  • there is no way to process the result during the operation. You have to wait and process everything in the end.

It would be nice if there was an unbuffered version that trigger the callback for each daemon event.

@daviddias
Copy link
Contributor

Agreed. This is also related with the progress bar support - ipfs/js-ipfs#879

In js-ipfs-api case with go-ipfs, it is really due to the nature of how the multipart message is created and how a http request is formed. We are aware that we need to level up our http-api to support things like this, see: https://github.com/ipfs/http-api-spec/issues/116

@daviddias
Copy link
Contributor

Released on v14.3.7 \o/

@ghost ghost removed the P0 - Critical label Oct 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants