Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

Correctly propagate errors sent with trailer headers #607

Closed
dryajov opened this issue Oct 15, 2017 · 1 comment
Closed

Correctly propagate errors sent with trailer headers #607

dryajov opened this issue Oct 15, 2017 · 1 comment

Comments

@dryajov
Copy link
Contributor

dryajov commented Oct 15, 2017

The changes in ipfs/js-ipfs#1036 have introduced errors through Trailer headers (x-stream-error), however, due to the way trailer headers are and our use of streams we can't correctly propagate them.

This is mainly a chicken and egg problem:

  1. we can't get Trailer headers unless the response ends
  2. we can't propagate the error, because the response stream ended

Since the processing of the request happens with through stream, once the response ends, our through streams end too, before getting a chance to communicate the error to them. We will possibly need to do some reworking of how we process responses because of that.

@dryajov
Copy link
Contributor Author

dryajov commented Nov 24, 2017

issues has been handled in - #636

@dryajov dryajov closed this as completed Nov 24, 2017
@ghost ghost removed the ready label Nov 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants