This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
Add files.get command and tests #296
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 15, 2016
Closed
hackergrrl
force-pushed
the
ipfs-files-get
branch
from
1f32d00
to
e4164f1
Compare
hackergrrl
force-pushed
the
ipfs-files-get
branch
from
e4164f1
to
5dcc4a0
Compare
|
@noffle I got a: Seems that on the interface-ipfs-core tests expect two different result types, check: |
|
Addressed! See ipfs-inactive/interface-js-ipfs-core#28 (comment) |
| @@ -0,0 +1,125 @@ | |||
| /* eslint-env mocha */ | |||
There was a problem hiding this comment.
Do these tests cover something that interface-ipfs-core tests don't cover? If yes, why not have all of them at interface-ipfs-core for get?
There was a problem hiding this comment.
I'm also getting am error from this file, which makes all the browser tests to fail:
ERROR in ./test/api/get.spec.js
Module build failed: TypeError: Cannot read property 'apply' of undefined
There was a problem hiding this comment.
I think I get it, these are the tests for the options supported by go-ipfs
|
Fixed the browser tests on https://github.com/ipfs/js-ipfs-api/tree/feat/ipfs.files.get :) |
|
Closed in favour of #337. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on @nginnever's work, bringing the rest of the implementation to completion.
Requires ipfs-inactive/interface-js-ipfs-core#28 to be merged first to get tests passing.