browser-add-file

[nycoliver]

Example showing broken file add in browser. See #344 (comment) and #335 for context.

[nycoliver]

Tests failing because FileReader is undefined in node environment. Not sure how to fix...

[nginnever]

Thanks for posting this @nycoliver

Tests failing because FileReader is undefined in node environment. Not sure how to fix...

That's just a linting error, so really just lint doesn't know about FileReader global since node never runs that example code. You could just instantiate a FileReader object at the scope you need with something like let FileReader

[daviddias]

@nycoliver please add /* globals FileReader */at the top and squash the commits for the merge :)

[daviddias]

@nycoliver looks all good now. Can you coalesce the commits?

git rebase -i HEAD~6
# squash them all
# reword the commit message to `feat(examples): add browser-add example` 

[nycoliver]

First pull request, almost got it...

[daviddias]

Here is a good tutorial http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html let me know if you run into trouble, I'm available on IRC as daviddias on the #IPFS channel in freenode

[daviddias]

Congrats on your first pull request 🎉🎉🎉🎉👏👏👏👏👏👏👏👏👏