add opts param to IpfsAPI, allow 'protocol' config

[ckeenan]

Should resolve #66

[victorb]

Is there a reason why we don't just make all the arguments opts? Instead of having host and port on separate arguments, they would be in opts as well. Ala #71 (comment)

[daviddias]

@victorbjelkholm I like that idea, but can we make it in a way that doesn't break current usage? (when we release a ipfsAPI 3.0.0 we can make breaking changes like that)

@ckeenan thank you for the PR, would you mind rebasing master first, so it gets a clean merge? + This seems to solve the problem also pointed out at #123 //cc @dignifiedquire ?

[ckeenan]

@diasdavid rebased

[daviddias]

LGTM. Just missing the documentation on the README.md.

@dignifiedquire @victorbjelkholm want to give your CR?

[dignifiedquire]

For this PR please add docs in readme, a test checking this works and move the build into a separate commit.

---

In general I think this is not the right approach though, what @jbenet mentioned makes much more sense we should start supporting new API('https://127.0.0.1:5001') and other forms of of addresses rather than forcing people to pass in the parsed values.

[daviddias]

Currently, ipfsAPI supports multiaddr https://github.com/ipfs/js-ipfs-api/blob/master/src/index.js#L19-L21, however it is expecting a /ip4/<ip>/tcp/<port> to use with http. Would it feel more right if it expected /ip4/<ip>/http/<port>? I would tend to say yes, but might be confusing to everyone thinking on the tcp ip:port way.

[dignifiedquire]

I think we should support:

'http://localhost:5001'
'//localhost:5001'
'/ip4/127.0.0.1/http/5001'
{ host: 'localhost', port: 5001, protocol: 'http'}

[ckeenan]

@diasdavid @dignifiedquire updated. Thoughts?

[dignifiedquire]

Can we put this into a new file, this is getting out of hand

[dignifiedquire]

Thanks @ckeenan functionality wise this looks good, left some cr comments

[ckeenan]

@dignifiedquire I updated with your requests. For multiple test files I parse the karma config's files for the mocha task, let me know if you want that handled differently

[dignifiedquire]

I suggest to rename the files to all in end .spec.js, so we can do test/*.spec.js

[dignifiedquire]

That way you can pass the same glob to the mocha config in tasks/test.js

[ckeenan]

Good idea. Added

[dignifiedquire]

Looks like you need to rebase on master again sorry :(

[ckeenan]

No worries @dignifiedquire

[dignifiedquire]

Thanks a lot. LGTM. So let's wait for @diasdavid to check and then we can ship this :)

[daviddias]

This is awesome, thank you @ckeenan and @dignifiedquire for reviewing it :) LGTM, going to merge and release