This repository was archived by the owner on Mar 10, 2020. It is now read-only.
fix: add lodash dependency #873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can someone explain to me why my commit breaks the "commitlint" process? ⧗ input:
Add lodash dependency; Closes #870
✖ message may not be empty [subject-empty]
✖ type may not be empty [type-empty]I'm commiting via bash in VSCode for Windows. Also, why does it timeout that much and how can I signal jenkins to try again? Regards. |
nGoline
force-pushed
the
fix/missing_lodash_dependency
branch
from
496dc05 to
5e73743
Compare
nGoline
changed the title
|
Sorry for I've missed that @hugomrdias. All set now! The only thing now is that I've changed nothing else than the dependency but I got an error on macos:10.11.0 test:node |
|
everything is passing now |
|
Thanks @nGoline |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add lodash as a dependency because it's required in 2 files.
This PR is related to PR 871.
@alanshaw this follows the requirements of the build tool. Sorry for that!