Skip to content
This repository was archived by the owner on Mar 10, 2020. It is now read-only.

Conversation

@vmx
Copy link
Contributor

@vmx vmx commented Nov 5, 2018

The test for types also exists in interface-ipfs-core, which is the
central test repository for both js-ipfs and js-http-api tests.
Pulling in the test once from there is enough.

The test for types also exists in interface-ipfs-core, which is the
central test repository for both js-ipfs and js-http-api tests.
Pulling in the test once from there is enough.
@vmx vmx requested a review from alanshaw November 5, 2018 18:13
@ghost ghost assigned vmx Nov 5, 2018
@ghost ghost added the in progress label Nov 5, 2018
@vmx
Copy link
Contributor Author

vmx commented Nov 6, 2018

CI passed. Only the branch tests failed which can't be retriggered.

Copy link
Contributor

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 👍

@alanshaw alanshaw merged commit 5841842 into master Nov 8, 2018
@ghost ghost removed the in progress label Nov 8, 2018
@alanshaw alanshaw deleted the remove-types-test branch November 8, 2018 16:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants