This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
docs(readme): remove CORS Credentials header #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTTP API does not need this and we should not ask people to set it if they don't really need it. License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
ghost
assigned 
alanshaw
approved these changes
Nov 30, 2018
|
Merging as CI failures are unrelated ping test failures (soon to be resolved in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(afaik) HTTP API does not need this and we should not ask people to set it if they don't really need it.
See also:
Access-Control-Allow-Credentials: [CORS] Old library makes exploitable CORS configuration (need to update dependency) ipfs/kubo#5745