Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

chore: update dependencies #973

Merged
merged 2 commits into from
Apr 29, 2019
Merged

chore: update dependencies #973

merged 2 commits into from
Apr 29, 2019

Conversation

alanshaw
Copy link
Contributor

No description provided.

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
@ghost ghost assigned alanshaw Apr 17, 2019
@ghost ghost added the in progress label Apr 17, 2019
@olizilla
Copy link
Contributor

The test that is failing is

  1) interface-ipfs-core tests
       .dht.provide
         should allow multiple CIDs to be passed:
     Uncaught TypeError: Cannot read property 'hash' of undefined
      at ipfs.add (node_modules/interface-ipfs-core/src/dht/provide.js:68:26)
      at f (node_modules/once/once.js:25:25)
      at result (src/files-regular/add.js:7:642)

In that test we call ipfs.add with an array of 2 buffers, and expect the result to contain an array of 2 ipfs file references, but it only contains 1.

https://github.com/ipfs/interface-js-ipfs-core/blob/fa21abb5ed9ff379e3ac5fb517592f8ea3acb1d7/src/dht/provide.js#L62-L74

ipfs.add([Buffer.from('t0'), Buffer.from('t1')], (err, res) => {
        if (err) return done(err)
        console.log({res})
        ipfs.dht.provide([
          new CID(res[0].hash),
          new CID(res[1].hash)

Cannot read property 'hash' of undefined is coming from the new CID(res[1].hash) line, as res[1] does not exit. res[0] does exist and has a hash property as expected. Why are we only getting 1 result back and not 2?

@olizilla
Copy link
Contributor

hmm, if i edit the test should add a Buffer as tuple to pass an array of more than 1 thing, it also fails

Fails - filesAdded.length === 1 not 2 as expected.

    it('should add a Buffer as tuple', (done) => {
      ipfs.add([
        { path: 'testfile.txt', content: fixtures.smallFile.data },
        { path: 'other.txt', content: fixtures.bigFile.data }
      ], (err, filesAdded) => {
        expect(err).to.not.exist()
        expect(filesAdded).to.have.length(2)
        done()
      })
    })

@olizilla
Copy link
Contributor

Dropping back to go-ipfs-dep@0.4.19 doesn't change anything. Test still fails. Time to go deeper.

@olizilla
Copy link
Contributor

Spoke to soon. Switching back to go-ipfs-dep@0.4.19 does cause the test to pass. Investigating 🔎

@olizilla
Copy link
Contributor

Cant add multiple files via the CLI in go-ipfs@0.4.20 ipfs/kubo#6254

@alanshaw alanshaw merged commit d759f3c into master Apr 29, 2019
@ghost ghost removed the in progress label Apr 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants