This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
fix: updates ipld-dag-pb dep to version without .cid or .multihash properties #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
N.b. this PR uses a github url for the ipld-dag-pb dependency temporarily and will need a new release of |
achingbrain
force-pushed
the
update-dag-pb-to-not-have-cid-property
branch
5 times, most recently
from
e2919db to
418ddfe
Compare
achingbrain
changed the title
Follows on from ipld/js-ipld-dag-pb#99 and updates this module to not rely on DAGNodes having knowledge of their CIDs. Bonus: also fixes #24 by removing use of js-ipfs from this module breaking another circular dependency from the project. License: MIT Signed-off-by: achingbrain <alex@achingbrain.net>
achingbrain
force-pushed
the
update-dag-pb-to-not-have-cid-property
branch
from
418ddfe to
fa9029d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows on from ipld/js-ipld-dag-pb#99 and updates this module to not rely on DAGNodes having knowledge of their CIDs.
Bonus: also fixes #24 by removing use of js-ipfs from this module breaking another circular dependency from the project.
License: MIT
Signed-off-by: achingbrain alex@achingbrain.net