This repository has been archived by the owner on Aug 12, 2020. It is now read-only.
Add support for rabin fingerprinting chunk algorithm #221
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This currently works as is, however the parameters
polynomial
andwindowsize
are not configurable by the rabin library used. This makes it difficult to compare the output the go-ipfs implementation, since both these parameters are set to different values there.I have opened a PR against the rabin library to allow for these parameters to be modified from javascript, dat-ecosystem-archive/rabin/pull/24.
Could use some advice on testing, the nature of the rabin chunking makes it difficult to test things like expected block sizes.
These changes are required for ipfs/js-ipfs/issues/1283