Skip to content
This repository has been archived by the owner on Aug 12, 2020. It is now read-only.

Add support for rabin fingerprinting chunk algorithm #221

Closed
wants to merge 3 commits into from

Conversation

dordille
Copy link
Contributor

This currently works as is, however the parameters polynomial and windowsize are not configurable by the rabin library used. This makes it difficult to compare the output the go-ipfs implementation, since both these parameters are set to different values there.

I have opened a PR against the rabin library to allow for these parameters to be modified from javascript, dat-ecosystem-archive/rabin/pull/24.

Could use some advice on testing, the nature of the rabin chunking makes it difficult to test things like expected block sizes.

These changes are required for ipfs/js-ipfs/issues/1283

@vmx
Copy link
Contributor

vmx commented Jul 26, 2018

Nice!

Someone with more better knowledge of the chunking should do an in-depth review. I just want to mention some more general things.

The CI is failing. It's due to linting errors (please run npm run lint before pushing) and wrongly formatted commit messages. We use a specific commit message format (so that the changelog can be auto-generated). Find more about that (and useful other things) in our JS Guidelines.

@dordille
Copy link
Contributor Author

Closing this in favor of #223, to resolve broken commit messages.

@dordille dordille closed this Jul 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants