This repository has been archived by the owner on Aug 12, 2020. It is now read-only.
fix(exporter): add some parallel fetching of blocks where possible #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddias
reviewed
Sep 23, 2016
| pull.flatten() | ||
| )), | ||
| )) | ||
| })), |
There was a problem hiding this comment.
@dignifiedquire could you please add a bit of documentation to this function, each time I come to read it, I scratch my head to get back to understand what is supposed to be going on
There was a problem hiding this comment.
Is /* this is where the magic happens */ enough?
There was a problem hiding this comment.
no. If is helpful to have diagrams, add a file to explain the internals with those graphs :) The unixfs-engine is a big piece of the files API and it needs to be easy to understand and pluggable so that we can extend it easily with other layouts, customs chunkers and so.
There was a problem hiding this comment.
@diasdavid added a description. Can we get this merged soon plese?
dignifiedquire
changed the title
daviddias
reviewed
Sep 26, 2016
| // 3.2. Switch on the node type | ||
| // - `directory`: return node | ||
| // - `file`: use the fileExporter to load and return the file | ||
| // 4. Flatten |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref ipfs/js-ipfs#498