This repository was archived by the owner on Apr 29, 2020. It is now read-only.
feat: create a DAG from a list of CID’s and sizes #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please note that this branch relies on another PR #45 |
achingbrain
added a commit
that referenced
this pull request
Jan 13, 2020
The interesting bits of this module are the various ways of building DAGs for files and folders (flat, sharded, etc). Sometimes we want to utilise bits of this logic to build DAGs without having to reimplement big chunks of this module. This PR allows the user to pass in functions to replace key parts of this import pipeline. Enables: * ipfs-inactive/js-ipfs-mfs#73 * #46
achingbrain
added a commit
that referenced
this pull request
Jan 15, 2020
* feat: allow overriding of internal functions The interesting bits of this module are the various ways of building DAGs for files and folders (flat, sharded, etc). Sometimes we want to utilise bits of this logic to build DAGs without having to reimplement big chunks of this module. This PR allows the user to pass in functions to replace key parts of this import pipeline. Enables: * ipfs-inactive/js-ipfs-mfs#73 * #46 * docs: add description about internal funcs
|
This should have been enabled by #48 - happy to close? |
|
yup, closing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This definitely needs a thorough review since this is a bit of a hack and I’m not all that familiar with this code.
This is a feature we need in order to generate custom file data structures from a pre-parsed array of parts. It’s a pretty unique use case and I’m not even sure we should document it as part of the public API.
This implementation seemed like the simplest way to accomplish the goal, but there may be a simpler way I missed.