This repository was archived by the owner on Apr 29, 2020. It is now read-only.
Integrate libp2p-ping #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is not happy :( |
|
@xicombd could you take a look and match it with the migration to pull streams (already done) |
fbaiodias
force-pushed
the
ping
branch
2 times, most recently
from
01d508e to
97dea09
Compare
|
@diasdavid build is now ✅ |
| p.stop() | ||
| done() | ||
| }) | ||
| }) |
There was a problem hiding this comment.
It does only send one ping? Something tells me this event will be fired up a bunch of times and the only thing preventing the test from failing is that it is the last test, so it closes soon enough
|
Sweet! @xicombd :D Made a comment on the test |
|
Things to do before finishing:
|
|
looking good @xicombd , just missing the same PR in libp2p-ipfs-browser and we are golden :D |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on libp2p/js-libp2p-ping#7