This repository has been archived by the owner on Oct 30, 2023. It is now read-only.
refactor: examples for js-ipfs 0.41 #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also removes the `react-live` preview component that uses `buble`. `buble` does not support `for await...of` loops. Instead we just run the code (in the same way that `react-live` does) without the transpile.
alanshaw
commented
Feb 11, 2020
| @@ -21,46 +20,40 @@ import { | |||
| import hexagonsSvg from 'shared/media/images/hexagons.sprite.svg' | |||
| import styles from './index.module.css' | |||
|
|
|||
| const CID_LENGTH = 46 | |||
There was a problem hiding this comment.
Removed in favour of is-ipfs because string length is a terrible check for whether something is a CID 😂
57 tasks
hugomrdias
approved these changes
Feb 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also removes the
react-livepreview component that usesbuble.bubledoes not supportfor await...ofloops. Instead we just run the code (in the same way thatreact-livedoes) without the transpile.