Skip to content
This repository has been archived by the owner on Jul 5, 2021. It is now read-only.

feat: add implementations section #282

Merged

Conversation

fsdiogo
Copy link
Contributor

@fsdiogo fsdiogo commented Dec 6, 2018

impl-section

Closes #281.

@fsdiogo
Copy link
Contributor Author

fsdiogo commented Dec 6, 2018

Also had to refactor the navbar because of the added item.

Desktop

l

Tablet

m

Mobile

s

Copy link
Contributor

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI I've restarted Jenkins and it did not fail the second time 🙃

Preview @ 796c673: https://ipfs.io/ipfs/QmUVWDeJ2dxsnNRizYqBcbwvGNzPMB6crHTwga4gdsya2b/

Preview @ 265ccd3: https://ipfs.io/ipfs/QmQd8T33h3wCxZpArNq6GAwyijofD412UcHi5V3Pbyg4ew/

(feedback below)

@fsdiogo
Copy link
Contributor Author

fsdiogo commented Dec 7, 2018

I like the change in the labels @lidel, thanks 👌

I'll change them.

Copy link
Contributor

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: I wonder if we should make both headers the same font size and remove the separator line?
Current version (https://ipfs.io/ipfs/QmQd8T33h3wCxZpArNq6GAwyijofD412UcHi5V3Pbyg4ew/) looks bit odd now, but I can't put my finger on what is exactly out of balance:

2018-12-09--11-13-20

@fsdiogo
Copy link
Contributor Author

fsdiogo commented Dec 10, 2018

I agree that something is a bit off @lidel. Fixed it with your suggestion:

screenshot 2018-12-10 at 11 17 31

@olizilla
Copy link
Collaborator

This is looking great @fsdiogo. Good tweaks too @lidel!

For the main menu, I think we can collapse Why, How, down to About... Why and how is a strong move for a menu, and I kinda love it, but there is a pile more content to fit in now, and it's getting difficult to justify having 3 entries where "about" would be customary.

I suggest moving implementations below the current "how" section, replacing why and how in the menu with "About" and ditch the link to uses... which would give us a top menu with.

About - Implementations - Install - Media - Docs - Blog

(for now...)

@olizilla
Copy link
Collaborator

screenshot 2018-12-10 at 22 46 50

@fsdiogo
Copy link
Contributor Author

fsdiogo commented Dec 11, 2018

@olizilla fancy 🌟 I like that suggestion. Commit incoming.

@olizilla
Copy link
Collaborator

olizilla commented Jan 8, 2019

We're waiting on apple developer cetificates for ipfs-desktop before rollling this out. The cert is required to get auto-update working on osx, and we don't want a bunch of folks to install it before that is available.

@daviddias
Copy link
Contributor

@olizilla should ipfs-desktop block everything else from being available? It would be great to have this as a great url/resource to share

@olizilla
Copy link
Collaborator

No it should not. We're waiting on the signing cert for windows. But we can simply hide it for now, and role this out today. We'll reveal desktop once those certs are in place.

@daviddias
Copy link
Contributor

@olizilla I think that is the best. This way you get two announcements for the cost of one aaand we get to share something today with the community. What about that? 👌🏽

@olizilla
Copy link
Collaborator

@fsdiogo can you hide ipfs-desktop from the list, so we can get this PR merged pls.

@fsdiogo
Copy link
Contributor Author

fsdiogo commented Jan 29, 2019

@olizilla can we merge this? (if we can please do so, I don't have permissions)

@olizilla olizilla merged commit 8f8d822 into ipfs-inactive:master Jan 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants