-
Notifications
You must be signed in to change notification settings - Fork 128
feat: add implementations section #282
feat: add implementations section #282
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI I've restarted Jenkins and it did not fail the second time 🙃
Preview @ 796c673: https://ipfs.io/ipfs/QmUVWDeJ2dxsnNRizYqBcbwvGNzPMB6crHTwga4gdsya2b/
Preview @ 265ccd3: https://ipfs.io/ipfs/QmQd8T33h3wCxZpArNq6GAwyijofD412UcHi5V3Pbyg4ew/
(feedback below)
- The odd "M" appears under the hamburger menu in Firefox (top right corner in narrow viewports)
- What if we change labels in "Apps" section to be more meaningful, for example (cc @olizilla ):
I like the change in the labels @lidel, thanks 👌 I'll change them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: I wonder if we should make both headers the same font size and remove the separator line?
Current version (https://ipfs.io/ipfs/QmQd8T33h3wCxZpArNq6GAwyijofD412UcHi5V3Pbyg4ew/) looks bit odd now, but I can't put my finger on what is exactly out of balance:
I agree that something is a bit off @lidel. Fixed it with your suggestion: |
This is looking great @fsdiogo. Good tweaks too @lidel! For the main menu, I think we can collapse Why, How, down to About... Why and how is a strong move for a menu, and I kinda love it, but there is a pile more content to fit in now, and it's getting difficult to justify having 3 entries where "about" would be customary. I suggest moving implementations below the current "how" section, replacing why and how in the menu with "About" and ditch the link to uses... which would give us a top menu with. About - Implementations - Install - Media - Docs - Blog (for now...) |
@olizilla fancy 🌟 I like that suggestion. Commit incoming. |
We're waiting on apple developer cetificates for ipfs-desktop before rollling this out. The cert is required to get auto-update working on osx, and we don't want a bunch of folks to install it before that is available. |
@olizilla should ipfs-desktop block everything else from being available? It would be great to have this as a great url/resource to share |
No it should not. We're waiting on the signing cert for windows. But we can simply hide it for now, and role this out today. We'll reveal desktop once those certs are in place. |
@olizilla I think that is the best. This way you get two announcements for the cost of one aaand we get to share something today with the community. What about that? 👌🏽 |
@fsdiogo can you hide ipfs-desktop from the list, so we can get this PR merged pls. |
@olizilla can we merge this? (if we can please do so, I don't have permissions) |
Closes #281.