Skip to content
This repository has been archived by the owner on Jul 5, 2021. It is now read-only.

Add ProtoSchool links to ipfs.io #318

Merged
merged 4 commits into from
Aug 12, 2019
Merged

Add ProtoSchool links to ipfs.io #318

merged 4 commits into from
Aug 12, 2019

Conversation

terichadbourne
Copy link
Contributor

Working on the multiple-button layout @olizilla suggested but my attempt to mix flexbox and tachyons is failing. I was envisioning 3 buttons across on a wider screen, stacked on mobile, but neither the wrapping or the bottom margin are taking. The CSS I found is all minimized (I'm not experienced with Hugo so may be looking in the wrong place).

@olizilla
Copy link
Collaborator

As far as I am aware, the ipfs.io website does not currently include tachyons, it users yeti.css from &yet, as they were commissed to build it many moons ago. The css is generated from less files, which you can find here https://github.com/ipfs/website/tree/master/less

@terichadbourne
Copy link
Contributor Author

Thanks @olizilla. The non-existence of Tachyons seems like a pretty good excuse for it not to be working. 😂

@terichadbourne
Copy link
Contributor Author

@fsdiogo & @lidel Helped me get the formatting working but we'd love feedback on the phrasing for these options:

image

@jessicaschilling
Copy link
Contributor

"look under the hood" is a little bit of an Americanism. What about "Want to dig in a little?" ... that also implies something that's still technical, but not as technical as someone who might want to read the whitepaper.

@momack2
Copy link
Contributor

momack2 commented Jul 29, 2019

The whitepaper is super out of date - might be better to do something like "want to see where it all began" or "want the technical vision" to indicate that this isn't actually the spec for the project as it exists today, but is a previous conception from 2014.

@terichadbourne
Copy link
Contributor Author

@olizilla I believe this three-button approach was your idea. Do you have any wording suggestions before we lock this down?

@terichadbourne terichadbourne requested a review from olizilla August 6, 2019 15:50
@terichadbourne
Copy link
Contributor Author

Based on feedback I've updated the wording and moved the whitepaper to the right to make it lower priority given its age.

image

Or on a narrower screen:
image

Note also the footer, which was updated in a previous commit to include ProtoSchool:
image

@terichadbourne terichadbourne marked this pull request as ready for review August 8, 2019 16:47
@terichadbourne
Copy link
Contributor Author

Can someone who knows Hugo(?) tell me where I would put CSS that needs to apply to content/index.html? There's a static/css/main.css but it's minified. The Yeti CSS doesn't appear to have the spacing features I need to ease the from wide to narrow screens so I think I'll need to do it myself to avoid this state:

image

@cwaring
Copy link
Contributor

cwaring commented Aug 8, 2019

The best place for any custom css will be in /less/pages/home.less. I would like to check this update alongside the new homepage quiz because now we are trying to guide people down a funnel it may be better to embed these actions within the appropriate section instead.

@terichadbourne
Copy link
Contributor Author

Thanks @cwaring. What's your ETA on actually pushing the quiz live on the website? Unless you're within a week-ish of shipping it, I'd argue we should knock this one out in the spirit of hotfixes and let ProtoSchool enjoy some extra traffic in the meantime.

Copy link
Contributor

@cwaring cwaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this locally and it works well as a stopgap. I'll merge this down now and we can continue to refine in a future PR as the quiz edges closer to launch :)

@cwaring cwaring merged commit 6b237ed into master Aug 12, 2019
@cwaring cwaring deleted the protoschool-links branch August 12, 2019 16:25
@terichadbourne terichadbourne changed the title WIP: Add ProtoSchool links to ipfs.io Add ProtoSchool links to ipfs.io Aug 12, 2019
@terichadbourne
Copy link
Contributor Author

this was part of our efforts to address ProtoSchool/protoschool.github.io#260

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants