feat: support custom compat protocol name #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanabi1224
force-pushed
the
custom-compat-protocol
branch
from
7e0bdf4
to
adef753
Compare
rkuhn
reviewed
May 19, 2023
src/behaviour.rs
Outdated
| @@ -26,6 +26,8 @@ use libp2p::core::either::EitherOutput; | |||
| use libp2p::core::{connection::ConnectionId, Multiaddr, PeerId}; | |||
| use libp2p::swarm::derive_prelude::{ConnectionClosed, DialFailure, FromSwarm, ListenFailure}; | |||
| #[cfg(feature = "compat")] | |||
| use libp2p::swarm::SubstreamProtocol; | |||
There was a problem hiding this comment.
please fold this into the following import
| impl UpgradeInfo for CompatMessage { | ||
| type Info = &'static [u8]; | ||
| type InfoIter = iter::Once<Self::Info>; | ||
|
|
||
| fn protocol_info(&self) -> Self::InfoIter { | ||
| iter::once(b"/ipfs/bitswap/1.2.0") | ||
| unimplemented!() |
There was a problem hiding this comment.
This smells bad: why not instead remove this impl?
There was a problem hiding this comment.
It requires more refactoring to remove UpgradeInfo impl for CompatMessage
There was a problem hiding this comment.
That refactoring is the required proof that this unimplemented!() won’t panic at runtime, though. In other words, I find it reasonable to demand that a production ready library does not contain unimplemented!().
There was a problem hiding this comment.
That makes sense! However, it's been too long since I made the PR, and I do need some extra time to pick up the context and made the change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
go-bitswapcompatible nodelibipldto make life easier when there're version conflicts in downstream crates. (e.g.libipld@0.15depends on a differentcidversion fromfvm_ipld_blockstore) and it's not yet possible to upgradefvm_ipld_blockstore, see chore: upgradecid,multihash,libipld-corecrates filecoin-project/ref-fvm#1380 (comment)Background:
go-bitswapallows customizing the protocol name with itsSettings.PrefixAPI, e.g. lotus uses"/chain"prefix,rust-bitswapshould be capable of matching the protocol name incompatmode. Please let me know your feedback, thanks!