Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Not on any boards" filter isn't consistently working #390

Closed
BigLep opened this issue Mar 29, 2022 · 25 comments
Closed

"Not on any boards" filter isn't consistently working #390

BigLep opened this issue Mar 29, 2022 · 25 comments
Assignees

Comments

@BigLep
Copy link

BigLep commented Mar 29, 2022

As part of go-ipfs triage we use the "not on any boards" filter extensively.

Example triage URL: https://ecosystem-research.herokuapp.com/all?org=ipfs&exclude_language%5B%5D=JavaScript&exclude_language%5B%5D=TypeScript&exclude_repo_full_name%5B%5D=ipfs%2Fipfs-companion&exclude_repo_full_name%5B%5D=ipfs%2Fipfs-desktop&exclude_repo_full_name%5B%5D=ipfs%2Fipfs-webui&exclude_repo_full_name%5B%5D=ipfs%2Fpublic-gateway-checker&exclude_repo_full_name%5B%5D=ipfs%2Fipfs-update&exclude_repo_full_name%5B%5D=ipfs%2Fawesome-ipfs&exclude_repo_full_name%5B%5D=ipfs%2Fcommunity&exclude_repo_full_name%5B%5D=ipfs%2Fdevgrants&exclude_repo_full_name%5B%5D=ipfs%2Fecosystem-directory&exclude_repo_full_name%5B%5D=ipfs%2Fipfs-website&exclude_repo_full_name%5B%5D=ipfs%2Fipfs-blog&exclude_repo_full_name%5B%5D=ipfs%2Fipfs-cluster&exclude_repo_full_name%5B%5D=ipfs%2Fgo-graphsync&exclude_repo_full_name%5B%5D=ipfs%2Fpinning-services-api-spec&exclude_repo_full_name%5B%5D=ipfs%2Fdistributions&exclude_repo_full_name%5B%5D=ipfs%2Fdistributed-wikipedia-mirror&exclude_repo_full_name%5B%5D=ipfs%2Fin-web-browsers&exclude_repo_full_name%5B%5D=ipfs%2Fjs-ipfs&exclude_repo_full_name%5B%5D=ipfs%2Faegir&range=360&state=open&per_page=100&sort=updated_at&order=desc&no_boards=true&community=true&exclude_core=true&type=pull_requests

As an example, this issue shows up: ipfs/kubo#8806

It is on a board though:
image

A couple of things:

  1. I have tried "refreshing" the issue in the ecosystem dashboard. That didn't change anything.
  2. We did more recently move to the new beta project boards in case that is affecting things.
  3. This isn't consistent. We do so many things get filtered out with the "not on any boards" filter. I haven't found a pattern as to why.
@andrew andrew self-assigned this Mar 29, 2022
@andrew
Copy link
Collaborator

andrew commented Mar 29, 2022

Will investigate now

@andrew
Copy link
Collaborator

andrew commented Mar 29, 2022

Looks like GitHub have changed something (could be the beta you mentioned) that has stopped generating events for when an issue/pull is added to a board, which was how it was detected before. I'll need to find another way to check if an issue has been added to a board

@andrew
Copy link
Collaborator

andrew commented Mar 29, 2022

There's definitely event data missing from the github rest api, I suspect i'll need to use the graphql api to get the board ids instead.

@andrew
Copy link
Collaborator

andrew commented Mar 29, 2022

@BigLep yep, it's caused by the new beta projects board, I think they've changed the authentication level required (no public in the api) so I may need to get an api token that has read:org access for all the PL orgs to get this working again.

@BigLep
Copy link
Author

BigLep commented Apr 1, 2022

@andrew : thanks for the response. Is API Token fetching something you would like me to help with?

I think you can make the request in the PLN Pathfinder (IT Support) Discord server: https://discord.gg/KUgWC5Te

@BigLep
Copy link
Author

BigLep commented Apr 8, 2022

Hi @andrew : just following up here to see if we have a way now to remove things off new triage boards. More of the teams have move to this, and we find the "don't show anything on a board" filter as useful as a way to denote whether something has been looked at previously or not during issue triage.

@andrew
Copy link
Collaborator

andrew commented Apr 8, 2022

@BigLep that discord link didn't work for me, can you resend or ping me on slack?

@BigLep
Copy link
Author

BigLep commented Apr 19, 2022

@andrew : any luck here? Let me know if there's a thread with Pathfinder I should followup on or give my support in.

@andrew
Copy link
Collaborator

andrew commented Apr 21, 2022

@BigLep pinged you in discord

@andrew
Copy link
Collaborator

andrew commented Apr 21, 2022

This should be working for all boards owned by the ipfs org now, the 'sync' button on each issue should update the board_ids field now too.

@BigLep
Copy link
Author

BigLep commented May 10, 2022

Hi @andrew . I can confirm it's working for IPFS. Can you please also do it for IPLD and libp2p?

@andrew
Copy link
Collaborator

andrew commented May 12, 2022

@BigLep I'll need to be added to the libp2 and ipld orgs to be able to update my token

BigLep added a commit to BigLep/github-mgmt that referenced this issue May 12, 2022
BigLep added a commit to BigLep/github-mgmt-1 that referenced this issue May 12, 2022
@BigLep
Copy link
Author

BigLep commented May 12, 2022

ACK. I have made the membership requests here. Once those are merged you should be unblocked.
libp2p/github-mgmt#8
ipld/github-mgmt#7

@andrew
Copy link
Collaborator

andrew commented May 13, 2022

I’m in both orgs now, IPLD already approved the oauth app, libp2p approval requested

@andrew
Copy link
Collaborator

andrew commented May 16, 2022

Still waiting for libp2p approval:
Screenshot 2022-05-16 at 09 51 01

I've resynced all the ipld issues as well, let me know if anything isn't looking right

@BigLep
Copy link
Author

BigLep commented May 16, 2022

@marten-seemann or @mxinden: can you please approve Anderw's oath request for libp2p? It will allow during triage for us to filter out issues that are already on a new github project board.

I think you can find the link to approve it here: https://github.com/organizations/libp2p/settings/oauth_application_policy

@marten-seemann
Copy link

Done.

@andrew
Copy link
Collaborator

andrew commented May 16, 2022

Thanks, will get the libp2p issues resynced first thing tomorrow

@andrew
Copy link
Collaborator

andrew commented May 17, 2022

Synced up the libp2p issues, let me know if there's anything else looking right

galargh pushed a commit to libp2p/github-mgmt that referenced this issue May 18, 2022
@BigLep
Copy link
Author

BigLep commented May 21, 2022

Thanks. I'll check during week of 2022-05-23.

@BigLep
Copy link
Author

BigLep commented May 27, 2022

@andrew : during 2022-05-27 triage, this item showed up libp2p/go-libp2p-core#234 event though it was already on a board and we are filtering out issues on a board.

@andrew
Copy link
Collaborator

andrew commented Jun 6, 2022

@BigLep investigating that now

@andrew
Copy link
Collaborator

andrew commented Jun 6, 2022

Found and fixed a bug with syncing boards, synced libp2p/go-libp2p-core#234 myself and it's now correctly being filtered out

@BigLep
Copy link
Author

BigLep commented Sep 15, 2022

@andrew : I think we're good to close this now, right?

@andrew andrew closed this as completed Sep 16, 2022
@andrew
Copy link
Collaborator

andrew commented Sep 16, 2022

Yep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants