-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement packages structure and publication #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moul
reviewed
Mar 9, 2020
moul
reviewed
Mar 9, 2020
gfanton
approved these changes
Mar 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
moul
approved these changes
Mar 13, 2020
aeddi
changed the title
feat: implement package structure and publication
feat: implement packages structure and publication
Mar 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The purpose of this PR is to make gomobile-ipfs available on Android/iOS package managers (Cocoapods and Gradle/Maven).
After discussion with my team, we chose to have a single version number for all packages (android/ios bridge/core/demo).
The version numbers of some packages will sometimes be bumped without changes, but it will be much easier to automate via the CI (tag, release, publish, etc...) and to use on the user side.
This PR requires to add secrets (Bintray, Cocoapods) in the repo settings to work.
As a second step, it would be nice to set up a Bintray repo in the name of IPFS, but I let the Protocol Labs teams take care of it so that they keep all sensitive information secret.
Related