Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps and fix tests #20

Merged
merged 4 commits into from
Jan 25, 2018
Merged

Update deps and fix tests #20

merged 4 commits into from
Jan 25, 2018

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Jan 24, 2018

No description provided.

@hacdias hacdias mentioned this pull request Jan 24, 2018
@hacdias hacdias requested a review from daviddias January 24, 2018 18:33
@hacdias
Copy link
Member Author

hacdias commented Jan 24, 2018

Adding err.notFound = true to line 74 seems to solve the problem. I think it wants us to specify that key when the error is Not Found.

@hacdias
Copy link
Member Author

hacdias commented Jan 24, 2018

@diasdavid I just did a small workaround to fix this. If you agree, I can merge this and release a new version.

src/mfs.js Outdated
@@ -71,6 +71,10 @@ module.exports = function (options) {

ipfsCtl.files.read(store.baseDir + opts.key, {}, (err, stream) => {
if (err) {
if (err.toString().indexOf('does not exist') > -1) {
err.notFound = true
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@daviddias daviddias merged commit 8d81bd4 into master Jan 25, 2018
@daviddias daviddias deleted the feat/updates branch January 25, 2018 01:20
@daviddias
Copy link
Member

@hacdias go ahead and release a new version :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants