Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependencies #615

Merged
merged 1 commit into from
Mar 15, 2018
Merged

chore: update dependencies #615

merged 1 commit into from
Mar 15, 2018

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Mar 15, 2018

Fixes #614. @olizilla, could you check if this branch works there without the startup problem?

@olizilla
Copy link
Member

👍 yep, that fixes #614 for me too!

@codecov-io
Copy link

codecov-io commented Mar 15, 2018

Codecov Report

Merging #615 into master will decrease coverage by 0.16%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #615      +/-   ##
==========================================
- Coverage   15.11%   14.94%   -0.17%     
==========================================
  Files          57       57              
  Lines         880      890      +10     
==========================================
  Hits          133      133              
- Misses        747      757      +10
Impacted Files Coverage Δ
src/controls/main/stats.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 628dea1...2e83488. Read the comment docs.

@bedri
Copy link

bedri commented Mar 15, 2018

Did you merge it with the master https://github.com/ipfs-shipyard/ipfs-desktop.git? I just clone the master and compiled it and when I run

npm start

It still gives the same error. It's OK if I clone the wrong branch. I will wait for a release. Otherwise I can confirm that it's not fixed for my case.

npm run test

passes all tests though.

Also it may be a good idea to upgrade versions of the deprecated packages listed below

npm WARN deprecated graceful-fs@3.0.11: please upgrade to graceful-fs 4 for compatibility with current and future versions of Node.js
npm WARN deprecated coffee-script@1.12.7: CoffeeScript on NPM has moved to "coffeescript" (no hyphen)
npm WARN deprecated jade@1.11.0: Jade has been renamed to pug, please install the latest version of pug instead of jade
npm WARN deprecated wrench@1.5.9: wrench.js is deprecated! You should check out fs-extra (https://github.com/jprichardson/node-fs-extra) for any operations you were using wrench for. Thanks for all the usage over the years.
npm WARN deprecated transformers@2.1.0: Deprecated, use jstransformer
npm WARN deprecated constantinople@3.0.2: Please update to at least constantinople 3.1.1
npm WARN deprecated nomnom@1.6.2: Package no longer supported. Contact support@npmjs.com for more info.
npm WARN deprecated minimatch@0.3.0: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue

Thank you in advance.

@bedri
Copy link

bedri commented Mar 16, 2018

While reading the other issues I catch the reason of the error happening after the last pull request. I was running an ipfs daemon in the background and ipfs-desktop also tries to start another daemon and hence the error occurs in my case. I closed the ipfs daemon and now ipfs-desktop started normally and GUI placed itself as a taskbar icon in OpenSUSE. So now I can confirm that the pull request fix works.

I think it will be a good idea to make ipfs-desktop checks any other ipfs daemon working in the background and gives an error message that says "An instance of ipfs is already working in daemon mode. Please stop the running ipfs daemon and re-run ipfs-desktop."
Or alternatively ipfs-desktop can just run GUI and use the already running daemon.

Thank you again.

@bedri bedri mentioned this pull request Mar 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants