-
Notifications
You must be signed in to change notification settings - Fork 872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update dependencies #615
Conversation
👍 yep, that fixes #614 for me too! |
Codecov Report
@@ Coverage Diff @@
## master #615 +/- ##
==========================================
- Coverage 15.11% 14.94% -0.17%
==========================================
Files 57 57
Lines 880 890 +10
==========================================
Hits 133 133
- Misses 747 757 +10
Continue to review full report at Codecov.
|
Did you merge it with the master https://github.com/ipfs-shipyard/ipfs-desktop.git? I just clone the master and compiled it and when I run
It still gives the same error. It's OK if I clone the wrong branch. I will wait for a release. Otherwise I can confirm that it's not fixed for my case.
passes all tests though. Also it may be a good idea to upgrade versions of the deprecated packages listed below
Thank you in advance. |
While reading the other issues I catch the reason of the error happening after the last pull request. I was running an ipfs daemon in the background and ipfs-desktop also tries to start another daemon and hence the error occurs in my case. I closed the ipfs daemon and now ipfs-desktop started normally and GUI placed itself as a taskbar icon in OpenSUSE. So now I can confirm that the pull request fix works. I think it will be a good idea to make ipfs-desktop checks any other ipfs daemon working in the background and gives an error message that says "An instance of ipfs is already working in daemon mode. Please stop the running ipfs daemon and re-run ipfs-desktop." Thank you again. |
Fixes #614. @olizilla, could you check if this branch works there without the startup problem?