Skip to content

chore: update multiaddr dep #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 7, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,20 +6,19 @@ stages:
- cov

node_js:
- '12'
- '10'

os:
- linux
- osx
- windows

script: npx nyc -s npm run test:node -- --bail
after_success: npx nyc report --reporter=text-lcov > coverage.lcov && npx codecov

jobs:
include:
- os: windows
cache: false

- stage: check
script:
- npx aegir commitlint --travis
Expand All @@ -38,5 +37,17 @@ jobs:
firefox: latest
script: npx aegir test -t browser -t webworker -- --browsers FirefoxHeadless

- stage: test
name: electron-main
os: osx
script:
- npx aegir test -t electron-main --bail

- stage: test
name: electron-renderer
os: osx
script:
- npx aegir test -t electron-renderer --bail

notifications:
email: false
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,13 @@
"dependencies": {
"bs58": "^4.0.1",
"cids": "~0.7.0",
"mafmt": "^6.0.7",
"multiaddr": "^6.0.4",
"mafmt": "^7.0.0",
"multiaddr": "^7.2.1",
"multibase": "~0.6.0",
"multihashes": "~0.4.13"
},
"devDependencies": {
"aegir": "^18.2.0",
"aegir": "^20.5.0",
"chai": "^4.2.0",
"pre-commit": "^1.2.2"
},
Expand Down
6 changes: 3 additions & 3 deletions test/test-multiaddr.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -86,15 +86,15 @@ describe('ipfs peerMultiaddr', () => {
].concat(goodCircuit)

it('isIPFS.peerMultiaddr should match a string with a valid IPFS peer', (done) => {
for (let addr of validPeerMultiaddrs) {
for (const addr of validPeerMultiaddrs) {
const actual = isIPFS.peerMultiaddr(addr)
expect(actual, `isIPFS.peerMultiaddr(${addr})`).to.equal(true)
}
done()
})

it('isIPFS.peerMultiaddr should match a valid Multiaddr instance', (done) => {
for (let addr of validPeerMultiaddrs) {
for (const addr of validPeerMultiaddrs) {
const ma = new Multiaddr(addr)
const actual = isIPFS.peerMultiaddr(ma)
expect(actual, `isIPFS.peerMultiaddr(${addr})`).to.equal(true)
Expand All @@ -103,7 +103,7 @@ describe('ipfs peerMultiaddr', () => {
})

it('isIPFS.peerMultiaddr should match a Buffer with multiaddr', (done) => {
for (let addr of validPeerMultiaddrs) {
for (const addr of validPeerMultiaddrs) {
const ma = new Multiaddr(addr)
const actual = isIPFS.peerMultiaddr((Buffer.from(ma.buffer)))
expect(actual, `isIPFS.peerMultiaddr(${addr})`).to.equal(true)
Expand Down