Improve support for IPNS double-hashed entries #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #40. This ensures that double-hashed IPNS entries both in modern and legacy forms are correctly supported, including both: * /ipns/<domain> * /ipns/key Before, only the modern form with /ipns/<domain> was correctly supported for double-hashed entries. Testcases have been added for all forms.
It was repeated in all check functions
lidel
approved these changes
Dec 12, 2024
Co-authored-by: Marcin Rataj <lidel@lidel.org>
Co-authored-by: Marcin Rataj <lidel@lidel.org>
Co-authored-by: Marcin Rataj <lidel@lidel.org>
Co-authored-by: Marcin Rataj <lidel@lidel.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40. This ensures that double-hashed IPNS entries both in modern and legacy forms are correctly supported, including both:
/ipns/<domain>/ipns/keyBefore, only the modern form with /ipns/ was correctly supported for double-hashed entries.
Testcases have been added for all forms.
The double-hashing check code that was duplicated in several functions has been consolidated.