Add bitswap commands #55
Conversation
Conflicts: ipfsApi/client.py
|
The code looks good, thanks. Could you write a quick test for each of the bitswap functions? If you follow the general model of the tests in 'test/functional/tests.py', it should be pretty easy. |
|
In-progress. Should have mentioned that above. |
|
Added the tests. Passing on my box but Travis seems to be taking a bit. |
|
The entire IPFS organization on Github shares one Travis instance. We On 08/16/2016 09:05 PM, Fred Thomsen wrote:
|
|
Guess waiting until morning is key. Life is good. |
| @@ -492,5 +492,28 @@ def test_object_patch_set_data(self): | |||
| self.assertEqual(result, | |||
| {'Hash': 'QmV4QR7MCBj5VTi6ddHmXPyjWGzbaKEtX2mx7axA5PA13G'}) | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
@Alexander255 just updated our testing framework to skip the functional tests if an IPFS daemon isn't running. It's a one-line change to make your tests have this feature. Take a look at this class decorator. If you could just throw that on this test class, I'm good to merge this.
|
👍 on this change once that decorator has been added. |
|
Done. |
|
@fredthomsen Thanks a ton for putting this together! Sorry that we kept adding todos as you went. |
Adding bitswap command as suggested by #42.
Closing #47.