Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new aegir always gives scary error #204

Closed
daviddias opened this issue Mar 12, 2018 · 2 comments
Closed

new aegir always gives scary error #204

daviddias opened this issue Mar 12, 2018 · 2 comments
Assignees

Comments

@daviddias
Copy link
Member

daviddias commented Mar 12, 2018

Can this be improved? //cc @vmx

image

It happens in modules that have no browser.js file.

@vmx
Copy link
Member

vmx commented Mar 12, 2018

Are you scared about the Module not found warning, or the webpack summary?

@daviddias
Copy link
Member Author

ahah I'm not "scared" :P, but it does print a ton of stuff for just not finding a browser.js (all of those lines are printed just because one file is not found).

vmx added a commit that referenced this issue Mar 12, 2018
Check if `test/browser.js` exist before webpack is initiated and require
it only if it really exist. This makes a warning go away that lead to
a lot of console output.

Fixes #204.
vmx added a commit that referenced this issue Mar 12, 2018
Check if `test/browser.js` exist before webpack is initiated and require
it only if it really exist. This makes a warning go away that lead to
a lot of console output.

Fixes #204.
vmx added a commit that referenced this issue Mar 28, 2018
Check if `test/browser.js` exist before webpack is initiated and require
it only if it really exist. This makes a warning go away that lead to
a lot of console output.

Fixes #204.
@vmx vmx closed this as completed in #205 Mar 28, 2018
vmx added a commit that referenced this issue Mar 28, 2018
Check if `test/browser.js` exist before webpack is initiated and require
it only if it really exist. This makes a warning go away that lead to
a lot of console output.

Fixes #204.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants