-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't publish examples on npm #303
Comments
Should we look at just whitelisting our packages rather than dealing with the .npmignore blacklisting? With most repos we'd be able to just add src and dist to the files property in package.json "files": [
"src",
"dist"
] The readme, license, changelog and package.json files will automatically be white listed. This would save us from random files that would be in peoples directories, such as editor files that .npmignore isn't covering. It's worth noting that .npmignore doesn't respect global git ignores. |
This looks like something the JS folks can handle with a script to update them all and a lint rule that checks for it. Sounds good? @alanshaw @achingbrain @vasco-santos @hugomrdias @jacobheun |
+1 on a script to update them. I have some half baked ideas about Also cc @hugomrdias |
This PR adds package.json linting with npm-package-json-lint and config for it. Check this issue #303 for context about these changes, not all issues are solve in this PR but still improves the current situation. //cc @ipfs/javascript-team
What is the time sink?
js-ipfs was publising examples which lead to huge download size due to publishing the dist folders of the examples. It got fixed here.
How do you think it can be solved?
I guess all projects should exclude the examples. If we agree on this all projects should be checked if they actually do it. Perhaps syncing the
.npmignore
files across repos.How important do you think this is to fix?
Not urgent.
The text was updated successfully, but these errors were encountered: