Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aegir should support .aegir.ts config file #943

Open
SgtPooki opened this issue Feb 24, 2022 · 1 comment
Open

aegir should support .aegir.ts config file #943

SgtPooki opened this issue Feb 24, 2022 · 1 comment
Assignees
@SgtPooki
Labels
effort/days Estimated to take multiple days, but less than a week exp/intermediate Prior experience is likely helpful kind/architecture Core architecture of project kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked topic/devexp Developer Experience

Comments

@SgtPooki
Copy link
Member

Is your feature request related to a problem? Please describe.
Creating an .aegir.cjs or .aegir.js config file in a typescript repo is unintuitive and archaic. We should be able to save our aegir config as typescript in a file such as .aegir.ts

Without a typescript config file, a typescript repo requires workarounds such as importing only transpiled source, using ts-node/register, or other obtrusive methods.

Describe the solution you'd like
Aegir should support creating a config file in typescript .aegir.ts. Most modern tools and libraries support typescript config files today.

Describe alternatives you've considered
adding

require('ts-node').register({
  project: 'tsconfig.json',
})

to the top of the .aegir.cjs file will allow you to import typescript files, but this shouldn't be required.

Additional context
We should fully adopt and encourage typescript usage.
@BigLep
Copy link

BigLep commented Mar 18, 2022

2022-03-18 maintainer conversation: sounds good. Do you want to implement @SgtPooki ?

@BigLep BigLep added the P2 Medium: Good to have, but can wait until someone steps up label Mar 18, 2022
@SgtPooki SgtPooki self-assigned this May 5, 2022
@SgtPooki SgtPooki added status/ready Ready to be worked kind/enhancement A net-new feature or improvement to an existing feature kind/architecture Core architecture of project exp/intermediate Prior experience is likely helpful effort/days Estimated to take multiple days, but less than a week topic/devexp Developer Experience labels May 5, 2022
SgtPooki added a commit that referenced this issue Jun 9, 2022
@SgtPooki
feat: support .aegir.ts config files
2339f73 
Fix #943
@SgtPooki SgtPooki linked a pull request Jun 9, 2022 that will close this issue
[WIP] feat: support aegir.ts config file #994
Closed
SgtPooki added a commit that referenced this issue Jun 23, 2022
@SgtPooki
feat: support .aegir.ts config files
bffecd9 
Fix #943
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SgtPooki SgtPooki

Labels
effort/days Estimated to take multiple days, but less than a week exp/intermediate Prior experience is likely helpful kind/architecture Core architecture of project kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked topic/devexp Developer Experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] feat: support aegir.ts config file ipfs/aegir
2 participants
@BigLep @SgtPooki