Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: point to esbuild bundle analysis tool instead of bundlebuddy #1447

Merged
merged 1 commit into from
Jan 12, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/build/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,9 @@
const maxsize = bytes(ctx.bundlesizeMax)
const diff = gzip - maxsize

task.output = 'Use https://www.bundle-buddy.com/ to load "./dist/stats.json".'
task.output = `Check previous sizes in https://bundlephobia.com/result?p=${pkg.name}@${pkg.version}`
task.output = 'Use https://esbuild.github.io/analyze/ to load "./dist/stats.json".'
// bundlephobia doesn't support exports maps properly
// task.output = `Check previous sizes in https://bundlephobia.com/result?p=${pkg.name}@${pkg.version}`

Check warning on line 100 in src/build/index.js

View check run for this annotation

Codecov / codecov/patch

src/build/index.js#L98-L100

Added lines #L98 - L100 were not covered by tests

if (diff > 0) {
throw new Error(`${bytes(gzip)} (▲${bytes(diff)} / ${bytes(maxsize)})`)
Expand Down
Loading